Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 21977 INT Part 2 - Fix Office User Select Counseling Office Validation #14603

Merged
merged 40 commits into from
Jan 21, 2025

Conversation

ajlusk
Copy link
Contributor

@ajlusk ajlusk commented Jan 16, 2025

B-21977

INT PR Part 1

Summary

Fixes some validation issues found during PO acceptance.

Also applies consistent "Required" hints to the orders form in the office ap per reviewer suggestion.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test (New steps in bold)

  1. Access the office app
  2. Login as a services counselor
  3. Navigate to the customer search page
  4. Search for any customer, maybe Spacemen, Leo
  5. Create a new move for you selected user
  6. On the orders form, are all required fields marked as such?
  7. When creating orders for your new move ensure the counseling office dropdown appears after selecting a current duty location that provides government counseling.
  8. Ensure the "Next" button remains disabled until all required fields are populated, specifically when all fields populated except the counseling office.
  9. Add any shipment to your newly created move so it will show up on your queue
  10. Navigate to your counseling queue, find the move you just created, and ensure the list counseling office matches the office you selected in step 7.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@ajlusk ajlusk added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels Jan 16, 2025
@ajlusk ajlusk self-assigned this Jan 16, 2025
@ajlusk ajlusk marked this pull request as ready for review January 16, 2025 22:08
@ajlusk ajlusk requested review from a team as code owners January 16, 2025 22:08
@r-mettler
Copy link
Contributor

Was able to create a move and saw that the Next button stays disabled until I select all fields including the counseling office as the final selection.

r-mettler
r-mettler previously approved these changes Jan 16, 2025
MInthavongsay
MInthavongsay previously approved these changes Jan 17, 2025
Copy link
Contributor

@MInthavongsay MInthavongsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ajlusk ajlusk removed the request for review from a team January 17, 2025 15:56
@ajlusk ajlusk requested a review from a team as a code owner January 17, 2025 19:34
antgmann
antgmann previously approved these changes Jan 17, 2025
Copy link
Contributor

@antgmann antgmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above comment resolved! Works great, thanks for the change
Edit: Removing approval because of client test issues

@antgmann antgmann self-requested a review January 17, 2025 19:51
@ajlusk ajlusk marked this pull request as draft January 17, 2025 20:45
@ajlusk ajlusk marked this pull request as ready for review January 17, 2025 22:44
Copy link
Contributor

@antgmann antgmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fixed, Happo approved, looks good 🚀

@ajlusk ajlusk merged commit 0bb2b26 into integrationTesting Jan 21, 2025
32 of 34 checks passed
@ajlusk ajlusk deleted the B-21977-INT3 branch January 21, 2025 15:14
@ajlusk ajlusk mentioned this pull request Jan 28, 2025
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.