-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 21977 INT Part 2 - Fix Office User Select Counseling Office Validation #14603
Conversation
Was able to create a move and saw that the Next button stays disabled until I select all fields including the counseling office as the final selection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above comment resolved! Works great, thanks for the change
Edit: Removing approval because of client test issues
MAIN-B-22196 ppm sit cost defect
…or_sc_too B21576 main add order types for sc too
B 22110 cicd optimizations jc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests fixed, Happo approved, looks good 🚀
B-21977
INT PR Part 1
Summary
Fixes some validation issues found during PO acceptance.
Also applies consistent "Required" hints to the orders form in the office ap per reviewer suggestion.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test (New steps in bold)
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots